Commit 886ca6f
authored
### Rationale for this change
It seems as part of #45089 `FileSystem.from_uri` was changed from a static function to a regular method. I believe this to be an error unintentionally introduced as part of the PR, based on the fact that this was not mentioned to be an explicit change, and the documentation attached to the function still shows it being called as a static method.
This changed was released as part of version 21.0. Previously, it was a static method on the class.
Now, when attempting to call `FileSystem.from_uri`, it breaks in two different cases:
1. Calling it as a class static method with an explicit `uri` argument.
2. Calling it as an instance method.
However, calling it as a class static method without an explicit `uri` argument (ex. `FileSystem.from_uri("/abc")`) still works.
This PR adds the `@ staticmethod` annotation back to this method.
### What changes are included in this PR?
`FileSystem.from_uri` is now a static method again.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
Yes, to the `FileSystem.from_uri` function.
* GitHub Issue: #47179
Authored-by: ff-kamal <[email protected]>
Signed-off-by: AlenkaF <[email protected]>
1 parent 940592b commit 886ca6f
2 files changed
+18
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
456 | 456 | | |
457 | 457 | | |
458 | 458 | | |
| 459 | + | |
459 | 460 | | |
460 | 461 | | |
461 | 462 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1642 | 1642 | | |
1643 | 1643 | | |
1644 | 1644 | | |
| 1645 | + | |
| 1646 | + | |
| 1647 | + | |
| 1648 | + | |
| 1649 | + | |
| 1650 | + | |
| 1651 | + | |
| 1652 | + | |
| 1653 | + | |
| 1654 | + | |
| 1655 | + | |
| 1656 | + | |
| 1657 | + | |
| 1658 | + | |
| 1659 | + | |
| 1660 | + | |
| 1661 | + | |
1645 | 1662 | | |
1646 | 1663 | | |
1647 | 1664 | | |
| |||
0 commit comments