Fix benchmarks; try gcc/clang compat

Author: WillAyd

cpp/src/arrow/util/byte_stream_split_internal.h

@@ -452,8 +452,9 @@ inline void ByteStreamSplitDecodeScalarDynamic(const uint8_t* data, int width,
 }
 
 template <int kNumStreams>
-void ByteStreamSplitDecodeSimdDispatch(const uint8_t* data, int width, int64_t num_values,
-                                       int64_t stride, uint8_t* out);
+ARROW_EXPORT void ByteStreamSplitDecodeSimdDispatch(const uint8_t* data, int width,
+                                                    int64_t num_values, int64_t stride,
+                                                    uint8_t* out);
 
 extern template ARROW_TEMPLATE_EXPORT void ByteStreamSplitDecodeSimdDispatch<2>(
     const uint8_t*, int, int64_t, int64_t, uint8_t*);

cpp/src/arrow/util/visibility.h

@@ -67,6 +67,11 @@
 #    ifndef ARROW_NO_EXPORT
 #      define ARROW_NO_EXPORT [[gnu::visibility("hidden")]]
 #    endif
+#    if defined(__clang__)
+#      define ARROW_TEMPLATE_EXPORT
+#    else
+#      define ARROW_TEMPLATE_EXPORT ARROW_EXPORT
+#    endif
 #  else
 // Not C++, or not gcc/clang
 #    ifndef ARROW_EXPORT
@@ -75,10 +80,10 @@
 #    ifndef ARROW_NO_EXPORT
 #      define ARROW_NO_EXPORT
 #    endif
+#    define ARROW_TEMPLATE_EXPORT
 #  endif
 
 #  define ARROW_FRIEND_EXPORT
-#  define ARROW_TEMPLATE_EXPORT ARROW_EXPORT
 
 // [[gnu::visibility("default")]] even when #included by a non-arrow source
 #  define ARROW_FORCE_EXPORT [[gnu::visibility("default")]]

cpp/src/parquet/meson.build

@@ -268,8 +268,6 @@ if needs_parquet_encryption
     }
 endif
 
-parquet_test_dep = [parquet_dep, arrow_test_dep, thrift_dep]
-
 if get_option('default_library') != 'static'
     parquet_test_support_lib = static_library(
         'parquet-test-support',
@@ -280,9 +278,18 @@ if get_option('default_library') != 'static'
     parquet_test_support_dep = declare_dependency(
         link_with: [parquet_test_support_lib],
     )
-    parquet_test_dep += [parquet_test_support_dep]
+else
+    parquet_test_support_dep = declare_dependency()
 endif
 
+
+parquet_test_dep = [
+    parquet_dep,
+    parquet_test_support_dep,
+    arrow_test_dep,
+    thrift_dep,
+]
+
 foreach key, val : parquet_tests
     test_name = 'parquet-@0@'.format(key)
     exc = executable(
@@ -313,7 +320,12 @@ parquet_benchmarks = {
     'size_stats_benchmark': {'sources': files('arrow/size_stats_benchmark.cc')},
 }
 
-parquet_benchmark_dep = [parquet_dep, arrow_benchmark_dep, thrift_dep]
+parquet_benchmark_dep = [
+    parquet_dep,
+    parquet_test_support_dep,
+    arrow_benchmark_dep,
+    thrift_dep,
+]
 
 foreach key, val : parquet_benchmarks
     benchmark_name = 'parquet-@0@'.format(key)