-
Notifications
You must be signed in to change notification settings - Fork 3.9k
GH-45427: [Python] Fix version comparison in pandas compat for pandas 2.3 dev version #45428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…pandas 2.3 dev version
|
@github-actions crossbow submit -g python |
Revision: a6e4d77 Submitted crossbow builds: ursacomputing/crossbow @ actions-99e2368119 |
The failing builds are also failing on the latest nightly run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jorisvandenbossche did you found out when testing on pandas side?
Probably here, right?
pandas-dev/pandas#60856
Just to get the reference on where was this found.
Not super relevant but to understand where was this coming from.
Yes, that PR and in general the pyarrow nightly CI on the 2.3 branch (or so any PR targetting that). We adjusted our tests for the case pyarrow >= 19 is installed, but that started failing because pyarrow now no longer returns the string dtype for 2.3.0.dev |
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 8fed34e. There were 8 benchmark results with an error:
There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…pandas 2.3 dev version (apache#45428) ### Rationale for this change Small follow-up on apache#45383 to ensure this version comparison also does the right thing for the currently not-yet-released dev version of 2.3.0 * GitHub Issue: apache#45427 Authored-by: Joris Van den Bossche <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
Rationale for this change
Small follow-up on #45383 to ensure this version comparison also does the right thing for the currently not-yet-released dev version of 2.3.0