Skip to content

Conversation

jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Feb 5, 2025

Rationale for this change

Small follow-up on #45383 to ensure this version comparison also does the right thing for the currently not-yet-released dev version of 2.3.0

Copy link

github-actions bot commented Feb 5, 2025

⚠️ GitHub issue #45427 has been automatically assigned in GitHub to PR creator.

@jorisvandenbossche
Copy link
Member Author

@github-actions crossbow submit -g python

Copy link

github-actions bot commented Feb 5, 2025

Revision: a6e4d77

Submitted crossbow builds: ursacomputing/crossbow @ actions-99e2368119

Task Status
example-python-minimal-build-fedora-conda GitHub Actions
example-python-minimal-build-ubuntu-venv GitHub Actions
test-conda-python-3.10 GitHub Actions
test-conda-python-3.10-hdfs-2.9.2 GitHub Actions
test-conda-python-3.10-hdfs-3.2.1 GitHub Actions
test-conda-python-3.10-pandas-latest-numpy-latest GitHub Actions
test-conda-python-3.10-substrait GitHub Actions
test-conda-python-3.11 GitHub Actions
test-conda-python-3.11-dask-latest GitHub Actions
test-conda-python-3.11-dask-upstream_devel GitHub Actions
test-conda-python-3.11-hypothesis GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-1.26 GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-latest GitHub Actions
test-conda-python-3.11-pandas-nightly-numpy-nightly GitHub Actions
test-conda-python-3.11-pandas-upstream_devel-numpy-nightly GitHub Actions
test-conda-python-3.11-spark-master GitHub Actions
test-conda-python-3.12 GitHub Actions
test-conda-python-3.12-cpython-debug GitHub Actions
test-conda-python-3.13 GitHub Actions
test-conda-python-3.9 GitHub Actions
test-conda-python-3.9-pandas-1.1.3-numpy-1.19.5 GitHub Actions
test-conda-python-emscripten GitHub Actions
test-cuda-python-ubuntu-22.04-cuda-11.7.1 GitHub Actions
test-debian-12-python-3-amd64 GitHub Actions
test-debian-12-python-3-i386 GitHub Actions
test-fedora-39-python-3 GitHub Actions
test-ubuntu-22.04-python-3 GitHub Actions
test-ubuntu-22.04-python-313-freethreading GitHub Actions
test-ubuntu-24.04-python-3 GitHub Actions

@jorisvandenbossche
Copy link
Member Author

The failing builds are also failing on the latest nightly run

Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorisvandenbossche did you found out when testing on pandas side?
Probably here, right?
pandas-dev/pandas#60856
Just to get the reference on where was this found.
Not super relevant but to understand where was this coming from.

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Feb 5, 2025
@jorisvandenbossche
Copy link
Member Author

Yes, that PR and in general the pyarrow nightly CI on the 2.3 branch (or so any PR targetting that). We adjusted our tests for the case pyarrow >= 19 is installed, but that started failing because pyarrow now no longer returns the string dtype for 2.3.0.dev

@raulcd raulcd merged commit 8fed34e into apache:main Feb 5, 2025
14 checks passed
@raulcd raulcd removed the awaiting merge Awaiting merge label Feb 5, 2025
@jorisvandenbossche jorisvandenbossche deleted the gh-45427 branch February 5, 2025 17:48
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 8fed34e.

There were 8 benchmark results with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

amoeba pushed a commit to amoeba/arrow that referenced this pull request Feb 11, 2025
…pandas 2.3 dev version (apache#45428)

### Rationale for this change

Small follow-up on apache#45383 to ensure this version comparison also does the right thing for the currently not-yet-released dev version of 2.3.0

* GitHub Issue: apache#45427

Authored-by: Joris Van den Bossche <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants