-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-45752: [C#] Update FlightInfo.cs with missing fields #45753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-45752: [C#] Update FlightInfo.cs with missing fields #45753
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
|
|
CurtHagenlocher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your help! Can you make one small change to FlightInfo please?
| } | ||
|
|
||
| public FlightInfo(Schema schema, FlightDescriptor descriptor, IReadOnlyList<FlightEndpoint> endpoints, long totalRecords = -1, long totalBytes = -1) | ||
| public FlightInfo(Schema schema, FlightDescriptor descriptor, IReadOnlyList<FlightEndpoint> endpoints, long totalRecords = -1, long totalBytes = -1, bool ordered = false, ByteString appMetadata=null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks binary compatibility, and there are scenarios where that matters. Could you add an overload with the additional parameters instead of changing the existing public constructor? The original constructor can chain to the new one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes Sure! Sorry for that, I am not a daily C# coder, and I need to warm up.
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit b2a9f98. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them. |
What changes are included in this PR?
add ordered and AppMetaData to FlightInfo.cs #45752
Are these changes tested?
YES
Are there any user-facing changes?
NO