Skip to content

GH-47009: [C#] ExportedAllocationOwner should use 64-bit integer to track total allocated memory.#47011

Merged
CurtHagenlocher merged 2 commits intoapache:mainfrom
marcin-krystianc:dev-20250707-integer_overflow
Jul 7, 2025
Merged

GH-47009: [C#] ExportedAllocationOwner should use 64-bit integer to track total allocated memory.#47011
CurtHagenlocher merged 2 commits intoapache:mainfrom
marcin-krystianc:dev-20250707-integer_overflow

Conversation

@marcin-krystianc
Copy link
Contributor

@marcin-krystianc marcin-krystianc commented Jul 7, 2025

Rationale for this change

Fixes #47009

What changes are included in this PR?

ExportedAllocationOwner now uses a 64-bit (instead of 32-bit) variable to track total allocated memory.

Are these changes tested?

yes

Are there any user-facing changes?

This PR contains a "Critical Fix".
Previously, it wasn't possible to export Record Batches larger than 2GB, it resulted in overflowing the integer variable that was used to track allocated memory.

@github-actions
Copy link

github-actions bot commented Jul 7, 2025

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@marcin-krystianc marcin-krystianc changed the title [c#] ExportedAllocationOwner should use 64-bit integer to track total allocated memory. GH-47009: [C#] ExportedAllocationOwner should use 64-bit integer to track total allocated memory. Jul 7, 2025
@github-actions
Copy link

github-actions bot commented Jul 7, 2025

⚠️ GitHub issue #47009 has been automatically assigned in GitHub to PR creator.

@CurtHagenlocher CurtHagenlocher merged commit 7135199 into apache:main Jul 7, 2025
11 checks passed
@CurtHagenlocher CurtHagenlocher removed the awaiting review Awaiting review label Jul 7, 2025
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 7135199.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 47 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[C#] Integer overflow in the ExportedAllocationOwner

2 participants