GH-46835: [C++] Add more configuration options to arrow::EqualOptions#47204
GH-46835: [C++] Add more configuration options to arrow::EqualOptions#47204kou merged 5 commits intoapache:mainfrom
Conversation
|
|
e5dfb9b to
098be5d
Compare
098be5d to
b5ab8ab
Compare
|
Dear @kou , could you review it? |
|
@github-actions crossbow submit preview-docs |
There was a problem hiding this comment.
Pull Request Overview
This PR adds more configuration options to arrow::EqualOptions to parameterize the comparison of metadata and schema in record batch equality checks. The changes allow users to control whether schema and metadata are considered during equality comparisons.
- Adds
use_schema()anduse_metadata()configuration methods toEqualOptions - Introduces a new overload for
RecordBatch::Equalsthat only takes anotherRecordBatchandEqualOptions - Refactors existing equality comparison methods to use the new options
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| cpp/src/arrow/compare.h | Adds use_schema_ and use_metadata_ fields with corresponding getter/setter methods to EqualOptions |
| cpp/src/arrow/record_batch.h | Adds new Equals overload and updates ApproxEquals to be inline with simplified implementation |
| cpp/src/arrow/record_batch.cc | Consolidates equality logic into single method that respects new schema/metadata options |
| cpp/src/arrow/record_batch_test.cc | Updates tests to use new API and adds comprehensive test coverage for new options |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Revision: b5ab8ab6841d9977394bab82ece6dcabee73d234 Submitted crossbow builds: ursacomputing/crossbow @ actions-f0c3a4f46f
|
|
Thank you for your feedback. I will look into it. |
b5ab8ab to
d2253c8
Compare
correct naming correct documentation comment add compare.h document comment on utilities.rst
774190e to
22a3544
Compare
|
@github-actions crossbow submit preview-docs |
|
Revision: 22a3544 Submitted crossbow builds: ursacomputing/crossbow @ actions-213c549c83
|
|
@github-actions crossbow submit preview-docs |
|
Revision: c876f0c Submitted crossbow builds: ursacomputing/crossbow @ actions-4c8f212ecc
|
|
@github-actions crossbow submit preview-docs |
|
Revision: 97aedd6 Submitted crossbow builds: ursacomputing/crossbow @ actions-dd2ad05b92
|
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 084a365. There weren't enough matching historic benchmark results to make a call on whether there were regressions. The full Conbench report has more details. |
Rationale for this change
Parameterizing the comparison of
metadataandarrow::Schemaviaarrow::EqualOptions.What changes are included in this PR?
arrow::EqualOptionsfor parameterizing the comparison ofmetadataandschema.Are these changes tested?
Yes, I ran the relevant unit tests.
Are there any user-facing changes?
use_schema()toarrow::EqualOptions.use_metadata()toarrow::EqualOptions.arrow::RecordBatch::Equalsthat accepts only anotherarrow::RecordBatchand anarrow::EqualOptionsinstance.