GH-47269: [C++][Acero] Support for multi threaded input: ScalarAggregateNode , GroupByNode and SortedMergeNode#47270
Closed
X-Lemon-X wants to merge 20 commits intoapache:mainfrom
Closed
GH-47269: [C++][Acero] Support for multi threaded input: ScalarAggregateNode , GroupByNode and SortedMergeNode#47270X-Lemon-X wants to merge 20 commits intoapache:mainfrom
X-Lemon-X wants to merge 20 commits intoapache:mainfrom
Conversation
added 5 commits
August 4, 2025 15:00
…calarAggregateNode and GroupByNode, to allow supoort of parallel execution
…der to ScalarAggregateNode and GroupByNode
…erminign of orderign shoule be enabled, added implicit ordering in scalar_agregate_node in keys are present before segmented keys.
|
|
added 6 commits
August 7, 2025 14:42
…allel veriable, added jitter to test to simulate sequence issues. Moved oredign check to MakeAggregateNodeArgs
…st cases when incoming batches are not in order.
…n GroupByNode and ScalarAggregateNode moved inputs from NodeArgs to Make fucniton to establish ordering
Member
|
This seems related to the discussion on: |
raulcd
reviewed
Aug 18, 2025
python/pyarrow/tests/test_table.py
Outdated
Comment on lines
+2986
to
+2987
| # with pytest.raises(NotImplementedError): | ||
| # table.group_by("b").aggregate([("a", "first")]) |
Member
There was a problem hiding this comment.
Is this commented for any reason?
Author
yes |
Member
|
@github-actions crossbow submit -g cpp |
github-actions
bot
added
awaiting committer review
|
Revision: 61f86f2 Submitted crossbow builds: ursacomputing/crossbow @ actions-e373717988
|
…o aggregate_sequencer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?
Yes. Users of those node must assert ordering on input where apropriate.