GH-47390: [C++][Acero] Allow for any type of scalar in Pivot longer features#47391
Open
gitmodimo wants to merge 5 commits intoapache:mainfrom
Open
GH-47390: [C++][Acero] Allow for any type of scalar in Pivot longer features#47391gitmodimo wants to merge 5 commits intoapache:mainfrom
gitmodimo wants to merge 5 commits intoapache:mainfrom
Conversation
added 5 commits
July 22, 2025 14:04
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Allow supplying any scalar as feature
What changes are included in this PR?
Support scalar in PivotLonger
Are these changes tested?
Yes
Are there any user-facing changes?
Yes.
This PR includes breaking changes to public APIs. (If there are any breaking changes to public APIs, please explain which changes are breaking. If not, you can remove this.)
Row templates now accept scalar as argument. To pass string and maintain the same operation user must pass string wrapped in std::make_shared().