GH-47429: [C++] Fix Flight Symbol Visibility on Windows#47430
Closed
WillAyd wants to merge 1 commit intoapache:mainfrom
Closed
GH-47429: [C++] Fix Flight Symbol Visibility on Windows#47430WillAyd wants to merge 1 commit intoapache:mainfrom
WillAyd wants to merge 1 commit intoapache:mainfrom
Conversation
WillAyd
requested review from
assignUser,
jonkeane,
kou,
lidavidm and
raulcd
as code owners
|
|
github-actions
bot
added
Component: C++
Component: FlightRPC
awaiting review
WillAyd
force-pushed
the
fix-flight-symbols
branch
from
639344c to
6199c78
Compare
Contributor
Author
|
Hmm this is a bit tricker than I thought with the CMake config. Closing for now - will take a closer look when I get a Windows machine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This fixes the protobuf generated header for flight to include export symbols, which makes it possible to build on Windows
What changes are included in this PR?
The protoc command in the CMake configuration for Flight has been updated
Are these changes tested?
Yes
Are there any user-facing changes?
No