GH-47422: [Python][C++][Flight] Expose ipc::ReadStats in Flight MetadataRecordBatchReader#47432
Merged
raulcd merged 7 commits intoapache:mainfrom Sep 4, 2025
Merged
GH-47422: [Python][C++][Flight] Expose ipc::ReadStats in Flight MetadataRecordBatchReader#47432raulcd merged 7 commits intoapache:mainfrom
raulcd merged 7 commits intoapache:mainfrom
Conversation
github-actions
bot
added
Component: C++
Component: Python
Component: FlightRPC
awaiting committer review
pitrou
reviewed
Aug 28, 2025
Member
pitrou
left a comment
pitrou
left a comment
There was a problem hiding this comment.
There's one nit and one question about the accounting of metadata-only messages, otherwise LGTM.
github-actions
bot
added
awaiting changes
github-actions
bot
added
awaiting change review
pitrou
approved these changes
Sep 2, 2025
Member
pitrou
left a comment
pitrou
left a comment
There was a problem hiding this comment.
LGTM except one small suggestion
… MetadataRecordBatchReader
github-actions
bot
added
awaiting changes
pitrou
approved these changes
Sep 3, 2025
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit cdea48e. There weren't enough matching historic benchmark results to make a call on whether there were regressions. The full Conbench report has more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Now that we have implemented dictionary replacement / dictionary deltas on DoGet/DoExchange, exposing ReadStatistics can help us easily understand / debug / diagnose much better what are the different messages being sent.
What changes are included in this PR?
Add API to expose
arrow::ipc::ReadStats stats()onMetadataRecordBatchReader. As we are mainly usingRecordBatchStreamReadereverywhere now, the stats are already populated so we just have to expose them.Add also Python bindings.
Are these changes tested?
Yes via several Python tests we are validating the stats are retrieved and the results are the expected ones.
Are there any user-facing changes?
No breaking changes, new API to retrieve Statistics from the readers.