Skip to content

GH-47560: [C++] Fix host handling for default HDFS URI #47458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pitrou merged 4 commits into from
Sep 23, 2025
Merged

GH-47560: [C++] Fix host handling for default HDFS URI #47458

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b230c0e
Fix host handling for default HDFS URI (fix for #25324 when used via …
dsevilla Aug 29, 2025
4561d70
Merge branch 'apache:main' into patch-3
dsevilla Sep 23, 2025
59d4d96
Update cpp/src/arrow/filesystem/hdfs.cc
dsevilla Sep 23, 2025
33adb02
Update comment for clarity on default host handling (fix comment length)
dsevilla Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion cpp/src/arrow/filesystem/hdfs.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,8 +363,14 @@ Result<HdfsOptions> HdfsOptions::FromUri(const Uri& uri) {
options_map.emplace(kv.first, kv.second);
}

// Special case host = "default" or "hdfs://default" as stated by GH-47560.
// If given the string "default", libhdfs selects the default filesystem
// from `core-site.xml`.
std::string host;
host = uri.scheme() + "://" + uri.host();
if (uri.host() == "default")
host = uri.host();
else
host = uri.scheme() + "://" + uri.host();

// configure endpoint
const auto port = uri.port();
Expand Down
Loading