Skip to content

GH-47512: [C++] Bump meson-fmt in pre-commit to 1.9.0#47513

Merged
WillAyd merged 1 commit intoapache:mainfrom
WillAyd:bump-meson-format
Sep 8, 2025
Merged

GH-47512: [C++] Bump meson-fmt in pre-commit to 1.9.0#47513
WillAyd merged 1 commit intoapache:mainfrom
WillAyd:bump-meson-format

Conversation

@WillAyd
Copy link
Contributor

@WillAyd WillAyd commented Sep 5, 2025

Rationale for this change

This improves the readability of parenthesized multi-line expressions in Meson configuration files

What changes are included in this PR?

meson-fmt in pre-commit has been bumped to version 1.9.0, and files have been cleaned accordingly

Are these changes tested?

Yes

Are there any user-facing changes?

No

@WillAyd WillAyd requested a review from raulcd as a code owner September 5, 2025 12:18
@github-actions
Copy link

github-actions bot commented Sep 5, 2025

⚠️ GitHub issue #47512 has been automatically assigned in GitHub to PR creator.

@WillAyd WillAyd added the CI: Extra Run extra CI label Sep 5, 2025
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Sep 5, 2025
@WillAyd WillAyd merged commit c558163 into apache:main Sep 8, 2025
43 of 44 checks passed
@WillAyd WillAyd removed the awaiting merge Awaiting merge label Sep 8, 2025
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit c558163.

There weren't enough matching historic benchmark results to make a call on whether there were regressions.

The full Conbench report has more details.

zanmato1984 pushed a commit to zanmato1984/arrow that referenced this pull request Oct 15, 2025
…7513)

### Rationale for this change

This improves the readability of parenthesized multi-line expressions in Meson configuration files

### What changes are included in this PR?

meson-fmt in pre-commit has been bumped to version 1.9.0, and files have been cleaned accordingly

### Are these changes tested?

Yes

### Are there any user-facing changes?

No
* GitHub Issue: apache#47512

Authored-by: Will Ayd <william.ayd@icloud.com>
Signed-off-by: Will Ayd <william.ayd@icloud.com>
@trim21
Copy link

trim21 commented Nov 21, 2025

it would nice if you could notice me that the regex for files is wrong...

@kou
Copy link
Member

kou commented Nov 22, 2025

Oh, I thought trim21/pre-commit-mirror-meson@e274126 is an expected change (but we don't need it).

@trim21
Copy link

trim21 commented Nov 22, 2025

Oh, I thought trim21/pre-commit-mirror-meson@e274126 is an expected change (but we don't need it).

what actually wrong is meson\.format, there is no such file but meson\.options

@kou
Copy link
Member

kou commented Nov 22, 2025

Ah, I didn't notice it.

How about using types: [meson] instead of files: ^(.*/)?(meson\.build|meson\.options)$? If we use types: [meson], we don't need to care about regex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments