GH-47564: [C++] Update expected L2 CPU cache range to 32KiB-64MiB#47563
GH-47564: [C++] Update expected L2 CPU cache range to 32KiB-64MiB#47563kou merged 1 commit intoapache:mainfrom matshch:increase-l2-cache
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
|
|
|
Do we need to do anything else there to merge this PR? |
|
I'll merge this in a few days if nobody objects it. |
|
@kou ping |
|
Oh, sorry. I forgot this... I'll merge this. |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 8e3d849. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
…iB (apache#47563) ### Rationale for this change On newer Apple silicon CPUs there is more L2 CPU cache than expected by the current unit tests. This results in the unit test failing: ``` /tmp/nix-build-arrow-cpp-20.0.0.drv-0/source/cpp/src/arrow/util/io_util_test.cc:1099: Failure Value of: l2 >= 32 * 1024 && l2 <= 12 * 1024 * 1024 Actual: false Expected: true unexpected L2 size: 16777216 [ FAILED ] CpuInfo.Basic (0 ms) ``` ### What changes are included in this PR? The expected L2 CPU cache range is increased to 32KiB-64MiB to accommodate newer CPUs. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#47564 Authored-by: Artem Leshchev <matshch@avride.ai> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Rationale for this change
On newer Apple silicon CPUs there is more L2 CPU cache than expected by the current unit tests. This results in the unit test failing:
What changes are included in this PR?
The expected L2 CPU cache range is increased to 32KiB-64MiB to accommodate newer CPUs.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.