GH-47919: [C++] Update Meson config for C Data Interface changes#47920
Merged
kou merged 2 commits intoapache:mainfrom Oct 30, 2025
Merged
GH-47919: [C++] Update Meson config for C Data Interface changes#47920kou merged 2 commits intoapache:mainfrom
kou merged 2 commits intoapache:mainfrom
Conversation
|
|
Contributor
Author
|
This is a follow on to #47888 to fix the Meson configuration. I don't believe its possible to actually test this with our current CI setup |
Contributor
Author
github-actions
bot
added
awaiting committer review
kou
reviewed
Oct 28, 2025
| arrow_c_data_integration_lib = library( | ||
| 'arrow_c_data_integration', | ||
| sources: ['c_data_integration_internal.cc'], | ||
| dependencies: [arrow_test_dep], |
Member
There was a problem hiding this comment.
Can we use arrow_test_dep_no_main?
See also: #47888 (comment)
github-actions
bot
added
awaiting changes
WillAyd
force-pushed
the
meson-extension-type-change
branch
from
2746ccf to
afde612
Compare
github-actions
bot
added
awaiting change review
Contributor
Author
Member
|
Let's merge in separately. |
WillAyd
force-pushed
the
meson-extension-type-change
branch
from
afde612 to
24443b4
Compare
Contributor
Author
|
Alrighty - looks like there was another PR that needed addressing as well. I've added as a second commit here to get us green - if you need me to split off into another PR let me know |
|
After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit 430ad81. None of the specified runs were found on the Conbench server. The full Conbench report has more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This retains parity with the CMake configuration
What changes are included in this PR?
C Data Interface library is created as a standalone
Are these changes tested?
No (not possible with current CI)
Are there any user-facing changes?
No