GH-48123 [C++][Float16] Reimplement arrow::WithinUlp and Enable it for float16#48224
GH-48123 [C++][Float16] Reimplement arrow::WithinUlp and Enable it for float16#48224pitrou merged 3 commits intoapache:mainfrom
Conversation
|
|
pitrou
left a comment
There was a problem hiding this comment.
This is neat, thank you. A couple comments below, but looks good on the principle.
|
@pitrou Thank you for the review. I’ve checked all the comments and will apply your suggestions in the coming days. |
67f5d3b to
f91d298
Compare
pitrou
left a comment
There was a problem hiding this comment.
LGTM, thank you @andishgar ! I've just pushed a very minor change and will merge if CI is ok.
|
@github-actions crossbow submit -g cpp |
|
Revision: 0597736 Submitted crossbow builds: ursacomputing/crossbow @ actions-aeed0cd233 |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit f40d62e. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 16 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
Refer to this comment. Additionally, this change enables
arrow::WithinUlpforfloat16.What changes are included in this PR?
Re-implement
arrow::WithinUlpand enable it forfloat16, including relevant tests for corner cases around powers of two andFloat16.Are these changes tested?
Yes, I ran the relevant unit tests.
Are there any user-facing changes?
No.