GH-44810: [C++][Parquet] Add arrow::Result version of parquet::arrow::FileReader::Make()#48285
Merged
kou merged 24 commits intoapache:mainfrom Dec 11, 2025
Merged
Conversation
|
|
kou
reviewed
Nov 28, 2025
86eba06 to
7ef530c
Compare
hiroyuki-sato
commented
Dec 1, 2025
Collaborator
Author
hiroyuki-sato
left a comment
There was a problem hiding this comment.
@kou CI passed Please take a look when you get a chacne.
kou
reviewed
Dec 1, 2025
hiroyuki-sato
commented
Dec 2, 2025
39cc9ea to
45249dd
Compare
f1abda7 to
4045dc8
Compare
Collaborator
Author
|
@kou Thank you for your review. I add |
kou
reviewed
Dec 11, 2025
|
After merging your PR, Conbench analyzed the 2 benchmarking runs that have been run so far on merge-commit 7a36fcc. There weren't enough matching historic benchmark results to make a call on whether there were regressions. The full Conbench report has more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
FileReader::Makepreviously returnedStatusand required callers to pass anoutparameter.What changes are included in this PR?
Introduce a
Result<std::unique_ptr<FileReader>>returning API to allow clearer error propagationAre these changes tested?
Yes.
Are there any user-facing changes?
Yes.
Status version
FileReader::Makehas been deprecated.arrow::Resultversion ofparquet::arrow::FileReader::Make()#44810