Skip to content

GH-48366: [GLib][Ruby] Add DictionaryEncodeOptions#48373

Merged
kou merged 1 commit intoapache:mainfrom
stenlarsson:glib-dictionary-encode-options
Dec 7, 2025
Merged

GH-48366: [GLib][Ruby] Add DictionaryEncodeOptions#48373
kou merged 1 commit intoapache:mainfrom
stenlarsson:glib-dictionary-encode-options

Conversation

@stenlarsson
Copy link
Copy Markdown
Contributor

@stenlarsson stenlarsson commented Dec 5, 2025

Rationale for this change

The DictionaryEncodeOptions class is not available in GLib/Ruby, and it is used together with the dictionary_encode compute function.

What changes are included in this PR?

This adds the DictionaryEncodeOptions class to GLib.

Are these changes tested?

Yes, with Ruby unit tests.

Are there any user-facing changes?

Yes, a new class.

@stenlarsson stenlarsson requested a review from kou as a code owner December 5, 2025 14:36
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 5, 2025

⚠️ GitHub issue #48366 has been automatically assigned in GitHub to PR creator.

Copy link
Copy Markdown
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou force-pushed the glib-dictionary-encode-options branch from 05f085b to bd0cb47 Compare December 7, 2025 06:42
@kou kou merged commit b14e109 into apache:main Dec 7, 2025
12 checks passed
@kou kou removed the awaiting review Awaiting review label Dec 7, 2025
@conbench-apache-arrow
Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit b14e109.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants