Skip to content

GH-48384: [C++][Docs][Parquet] Fix broken link for parquet-format spec#48385

Merged
kou merged 2 commits intoapache:mainfrom
ArnavBalyan:arnavb/fix-parquet
Dec 7, 2025
Merged

GH-48384: [C++][Docs][Parquet] Fix broken link for parquet-format spec#48385
kou merged 2 commits intoapache:mainfrom
ArnavBalyan:arnavb/fix-parquet

Conversation

@ArnavBalyan
Copy link
Copy Markdown
Member

@ArnavBalyan ArnavBalyan commented Dec 7, 2025

Rationale for this change:

  • Broken link for dictionary spec for parquet.
  • Fixes the same

What changes are included in this PR?

  • Same as above

Are these changes tested?

  • Yes, CI

Are there any user-facing changes?

  • Yes, doc update

@ArnavBalyan ArnavBalyan requested a review from wgtmac as a code owner December 7, 2025 06:49
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 7, 2025

⚠️ GitHub issue #48384 has been automatically assigned in GitHub to PR creator.

@ArnavBalyan
Copy link
Copy Markdown
Member Author

cc @pitrou could you ptal thanks! :)

@kou kou changed the title GH-48384: [Parquet] Fix broken link for parquet-format spec GH-48384: [C++][Docs][Parquet] Fix broken link for parquet-format spec Dec 7, 2025
Copy link
Copy Markdown
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Could you fix the lint failure by nice pre-commit run --show-diff-on-failure --color=always --all-files cpp?

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Dec 7, 2025
@ArnavBalyan
Copy link
Copy Markdown
Member Author

+1

Could you fix the lint failure by nice pre-commit run --show-diff-on-failure --color=always --all-files cpp?

updated thanks

@kou kou merged commit f66887e into apache:main Dec 7, 2025
40 checks passed
@kou kou removed the awaiting merge Awaiting merge label Dec 7, 2025
@conbench-apache-arrow
Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit f66887e.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants