GH-48395: [C++][Dev] Update fuzzing CMake preset#48396
Conversation
|
@kou Does this look ok? |
cpp/CMakePresets.json
Outdated
| "CMAKE_BUILD_TYPE": "Debug", | ||
| "CMAKE_C_COMPILER": "clang", | ||
| "CMAKE_CXX_COMPILER": "clang++", | ||
| "ARROW_DEPENDENCY_SOURCE": "BUNDLED", |
There was a problem hiding this comment.
Any particular reason we have to use the BUNDLED approach for this?
There was a problem hiding this comment.
I want to know it too. Is it for generating more information in backtrace?
There was a problem hiding this comment.
It's so that dependencies are properly instrumented by ASan/UBSan. Otherwise we might miss some bugs.
There was a problem hiding this comment.
(if only JSON allowed comments, I could add one here...)
There was a problem hiding this comment.
We can use "$comment" key in CMakePresets.json: https://cmake.org/cmake/help/latest/manual/cmake-presets.7.html#format
There was a problem hiding this comment.
Only with CMake 3.31 and higher apparently, is that ok for us?
github-actions
bot
added
awaiting committer review
cpp/CMakePresets.json
Outdated
| "CMAKE_BUILD_TYPE": "Debug", | ||
| "CMAKE_C_COMPILER": "clang", | ||
| "CMAKE_CXX_COMPILER": "clang++", | ||
| "ARROW_DEPENDENCY_SOURCE": "BUNDLED", | ||
| "ARROW_CSV": "ON", | ||
| "ARROW_IPC": "ON", | ||
| "ARROW_PARQUET": "ON", | ||
| "PARQUET_REQUIRE_ENCRYPTION": "ON", | ||
| "ARROW_FUZZING": "ON", | ||
| "ARROW_WITH_SNAPPY": "ON" | ||
| "ARROW_WITH_BROTLI": "ON", | ||
| "ARROW_WITH_LZ4": "ON", | ||
| "ARROW_WITH_SNAPPY": "ON", | ||
| "ARROW_WITH_ZLIB": "ON", | ||
| "ARROW_WITH_ZSTD": "ON" |
There was a problem hiding this comment.
Could you sort them like other presets do?
cpp/CMakePresets.json
Outdated
| "CMAKE_BUILD_TYPE": "Debug", | ||
| "CMAKE_C_COMPILER": "clang", | ||
| "CMAKE_CXX_COMPILER": "clang++", | ||
| "ARROW_DEPENDENCY_SOURCE": "BUNDLED", |
There was a problem hiding this comment.
I want to know it too. Is it for generating more information in backtrace?
github-actions
bot
added
awaiting review
We have more features enabled on our fuzzing setup but we haven't updated the corresponding CMake preset.
pitrou
force-pushed
the
gh48395-cmake-fuzzing-preset
branch
from
885d7c7 to
b737876
Compare
github-actions
bot
added
awaiting changes
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit f65ee2c. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
3 participants
Rationale for this change
We have more features enabled on our fuzzing setup but we haven't updated the corresponding CMake preset.
Are these changes tested?
Manually.
Are there any user-facing changes?
No.