GH-48412: [Ruby] Add support for reading date32 array#48413
Merged
kou merged 1 commit intoapache:mainfrom Dec 9, 2025
Merged
Conversation
|
|
github-actions
bot
added
Component: Ruby
awaiting committer review
hiroyuki-sato
approved these changes
Dec 9, 2025
Collaborator
hiroyuki-sato
left a comment
hiroyuki-sato
left a comment
There was a problem hiding this comment.
+1
LD_LIBRARY_PATH=/tmp/local/lib GI_TYPELIB_PATH=/tmp/local/lib/girepository-1.0 ./test/run.rb
Loaded suite test
Started
/path/to/arrow/ruby/red-arrow-format/lib/arrow-format/file-reader.rb:62: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
Finished in 0.183524749 seconds.
--------------------------------------------------------------------------------
13 tests, 13 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
--------------------------------------------------------------------------------
70.84 tests/s, 70.84 assertions/s
| case fb_type.unit | ||
| when Org::Apache::Arrow::Flatbuf::DateUnit::DAY | ||
| type = Date32Type.singleton | ||
| end |
Collaborator
There was a problem hiding this comment.
Just in case: DateUnit::MILLISECOND will implement aonther PR?
Member
Author
|
@github-actions crossbow submit test-debian-ruby |
|
Revision: 77c2e03 Submitted crossbow builds: ursacomputing/crossbow @ actions-50eb834dfd
|
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 9c1a05c. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
It's a day variant of date array.
What changes are included in this PR?
ArrowFormat::Date32TypeArrowFormat::Date32ArrayAre these changes tested?
Yes.
Are there any user-facing changes?
Yes.