Skip to content

Conversation

@HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Dec 11, 2025

Rationale for this change

The original ticket ARROW-4258 missed the followup task, see also #3395 (comment)

Adding the test originally intended to test.

What changes are included in this PR?

Added the tests dates with masks

Are these changes tested?

Yes, manually tested as below:

python3 -m pytest pyarrow/tests/test_pandas.py::test_create_date32_and_date64_arrays_with_mask

Are there any user-facing changes?

No, test-only.

@github-actions
Copy link

⚠️ GitHub issue #48452 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Dec 15, 2025
@HyukjinKwon HyukjinKwon changed the title GH-48452: [Python] Add a test for safe cast from NumPy float64 array to integer GH-48452: [Python] Add tests for Date32 and Date64 array creation with masks Dec 23, 2025
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Dec 23, 2025
Copy link
Member

@AlenkaF AlenkaF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AlenkaF AlenkaF merged commit de9ff0d into apache:main Jan 7, 2026
14 checks passed
@AlenkaF AlenkaF removed the awaiting change review Awaiting change review label Jan 7, 2026
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit de9ff0d.

There weren't enough matching historic benchmark results to make a call on whether there were regressions.

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants