Skip to content

GH-48557: [C++][Parquet][CI] Also encrypt nested columns in fuzz seed corpus#48558

Merged
pitrou merged 1 commit intoapache:mainfrom
pitrou:gh48557-fuzz-encrypt-nested-columns
Dec 16, 2025
Merged

GH-48557: [C++][Parquet][CI] Also encrypt nested columns in fuzz seed corpus#48558
pitrou merged 1 commit intoapache:mainfrom
pitrou:gh48557-fuzz-encrypt-nested-columns

Conversation

@pitrou
Copy link
Copy Markdown
Member

@pitrou pitrou commented Dec 16, 2025

Rationale for this change

In #48336 we skipped encrypted nested columns because it was too cumbersome to configure (each leaf column had to be configured independently).

Now that #45462 has been merged we can configure nested columns the same way as non-nested ones.

Are these changes tested?

Manually and later by OSS-Fuzz.

Are there any user-facing changes?

No.

@pitrou
Copy link
Copy Markdown
Member Author

pitrou commented Dec 16, 2025

@github-actions crossbow submit fuzz

@pitrou pitrou marked this pull request as ready for review December 16, 2025 12:25
@pitrou pitrou requested a review from wgtmac as a code owner December 16, 2025 12:25
@pitrou
Copy link
Copy Markdown
Member Author

pitrou commented Dec 16, 2025

@EnricoMi Would you like to review this?

@github-actions
Copy link
Copy Markdown

Revision: c06eaa9

Submitted crossbow builds: ursacomputing/crossbow @ actions-1504e3f67a

Task Status
test-build-cpp-fuzz GitHub Actions

@pitrou
Copy link
Copy Markdown
Member Author

pitrou commented Dec 16, 2025

Also cc @adamreeve

Copy link
Copy Markdown
Collaborator

@EnricoMi EnricoMi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Dec 16, 2025
@pitrou pitrou merged commit d2ec684 into apache:main Dec 16, 2025
42 of 44 checks passed
@pitrou pitrou removed the awaiting committer review Awaiting committer review label Dec 16, 2025
@pitrou pitrou deleted the gh48557-fuzz-encrypt-nested-columns branch December 16, 2025 16:13
@conbench-apache-arrow
Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit d2ec684.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 7 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants