-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-48478: [Ruby] Fix Ruby list inference for nested non-negative integer arrays #48584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
3995400
GH-48478: Fix Ruby list inference for nested non-negative integer arrays
hypsakata 53c8fca
Add tests for nested integer array inference in Arrow::Table.new
hypsakata 51b94d2
Remove unnecessary boolean conversion
hypsakata 72092f6
Move tests from test-table.rb to test-array-builder.rb
hypsakata 2514fb3
Verify data type and values in list array tests
hypsakata File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -72,6 +72,18 @@ def array_like.to_ary | |||||||||||||||||||||||||||||||||
| assert_equal(Arrow::Table.new(schema, [Arrow::UInt8Array.new([1, 2, 3])]), | ||||||||||||||||||||||||||||||||||
| Arrow::Table.new(numbers: array_like)) | ||||||||||||||||||||||||||||||||||
| end | ||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
| test("{Symbol: nested non-negative integer Array}") do | ||||||||||||||||||||||||||||||||||
| table = Arrow::Table.new(numbers: [[0, 1, 2], [3, 4]]) | ||||||||||||||||||||||||||||||||||
| assert_equal("list<item: uint8>", | ||||||||||||||||||||||||||||||||||
| table.schema["numbers"].data_type.to_s) | ||||||||||||||||||||||||||||||||||
| end | ||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
| test("{Symbol: nested signed integer Array}") do | ||||||||||||||||||||||||||||||||||
| table = Arrow::Table.new(numbers: [[0, -1, 2], [3, 4]]) | ||||||||||||||||||||||||||||||||||
| assert_equal("list<item: int8>", | ||||||||||||||||||||||||||||||||||
| table.schema["numbers"].data_type.to_s) | ||||||||||||||||||||||||||||||||||
| end | ||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||
| test("list<boolean>s") do | |
| assert_build(Arrow::ArrayBuilder, | |
| [ | |
| [nil, true, false], | |
| nil, | |
| [false], | |
| ]) | |
| end | |
| test("list<string>s") do | |
| assert_build(Arrow::ArrayBuilder, | |
| [ | |
| ["Hello", "World"], | |
| ["Apache Arrow"], | |
| ]) | |
| end |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this
!!for convertingniltofalse?If so, we don't need it because
nilis also a false value.