GH-48735: [CI][Python] Fix macOS wheel builds by forcing setuptools upgrade in venv #48739
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uirements-wheel-build.txt
github-actions
bot
added
awaiting review
Member
|
@github-actions crossbow submit wheel-macos-monterey-* |
|
Revision: 144e05b Submitted crossbow builds: ursacomputing/crossbow @ actions-389d7a670d
|
Member
Author
|
Let me take a look at the test failure. |
Member
Author
|
@github-actions crossbow submit wheel-macos-monterey-* |
|
Revision: 6e371d5 Submitted crossbow builds: ursacomputing/crossbow @ actions-98ec6a6d4e
|
Member
Author
|
@github-actions crossbow submit wheel-macos-monterey-* |
|
Revision: 51677cf Submitted crossbow builds: ursacomputing/crossbow @ actions-61d9a49410
|
Member
Author
|
@github-actions crossbow submit wheel-macos-monterey-* |
|
Revision: b1c9cc9 Submitted crossbow builds: ursacomputing/crossbow @ actions-86ccd629ef
|
HyukjinKwon
changed the title
Member
Author
|
Should be ready for a look. |
github-actions
bot
added
awaiting merge
HyukjinKwon
force-pushed
the
GH-48735-2
branch
from
b1c9cc9 to
8eaf42c
Compare
Member
Author
|
I rebased to retrigger the test. The test failures should be unrelated. |
HyukjinKwon
changed the title
AlenkaF
approved these changes
Jan 7, 2026
Member
AlenkaF
left a comment
AlenkaF
left a comment
There was a problem hiding this comment.
This is great, thank you for such a quick fix!!
Member
Author
|
YAY! |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 2184116. There weren't enough matching historic benchmark results to make a call on whether there were regressions. The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Commit 866502e updated
pyproject.tomlto use the license formatlicense = "Apache-2.0"and requiredsetuptools>=77in[build-system].However, macOS wheel builds for Python 3.10 were failing with:
While Python 3.12 builds passed with identical code.
When
python -m venv build-envcreates the virtual environment, Python 3.10's venv inherits an older setuptools from the system Python installation. The build script usespip install --targetwhich seems not upgrading existing packages, leaving the old setuptools active for some reasons.Evidence from Python 3.10 logs:
Python 3.12 had no such warnings and used the fresh setuptools-80.9.0.
What changes are included in this PR?
In
ci/scripts/python_wheel_macos_build.sh, added--upgrade --force-reinstallflags to pip install command to force replacement of any old setuptools inherited from system PythonIn addition, also added
setuptools>=77atpython/requirements-wheel-build.txtto match with the original PR.Are these changes tested?
Tested in CI: #48739 (comment)
Are there any user-facing changes?
No, test/dev-only.