Skip to content

GH-48787: [C++] Disable -Werror for s2n-tls #48791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 4 commits into from
Jan 11, 2026
+5 −0
Merged

GH-48787: [C++] Disable -Werror for s2n-tls #48791

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7ebcda0
build: upgrade s2n-tls and fix CMake 4.0 compatibility
meher745 Jan 8, 2026
5852bc1
build: disable -Werror for s2n-tls as recommended
meher745 Jan 9, 2026
0b3cc89
build: disable -Werror for s2n-tls to fix Ubuntu 24.04 CI
meher745 Jan 9, 2026
92b2cd0
chore: restore testing submodule to match upstream
meher745 Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions cpp/cmake_modules/ThirdpartyToolchain.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3984,6 +3984,11 @@ function(build_awssdk)
# We don't need to link aws-lc. It's used only by s2n-tls.
elseif("${AWSSDK_PRODUCT}" STREQUAL "s2n-tls")
list(PREPEND AWSSDK_LINK_LIBRARIES s2n)
# Disable -Werror for s2n-tls: it has Clang 18 warnings that it intentionally allows.
# See: https://github.com/aws/s2n-tls/issues/5696
if(TARGET s2n)
target_compile_options(s2n PRIVATE -Wno-error)
endif()
else()
list(PREPEND AWSSDK_LINK_LIBRARIES ${AWSSDK_PRODUCT})
# This is for find_package(aws-*) in aws-crt-cpp and aws-sdk-cpp.
Expand Down
Loading