-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-48811: [C++][FlightRPC] ODBC: Add missing arrow:: to fix build
#48810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @lidavidm could you take a look at this minor PR? Thanks! cc @HyukjinKwon |
HyukjinKwon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for catching this. I think I shouldn't touch this code path till my env is fully ready 😅
|
Oh BTW I believe this needs a ticket instead of marking it a minor |
arrow:: to fix buildarrow:: to fix build
|
|
No worries! Ty for taking a look |
kou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 6c7de4e. There weren't enough matching historic benchmark results to make a call on whether there were regressions. The full Conbench report has more details. |
Rationale for this change
Add
arrow::toDecimal128Type::kMaxPrecisionto fix the buildWhat changes are included in this PR?
arrow::as prefix toDecimal128Type::kMaxPrecisionAre these changes tested?
Are there any user-facing changes?
N/A