GH-48120: [C++][ODBC] Remove and replace IsComplexType with is_nested#48847
Open
AestheticAkhmad wants to merge 1 commit intoapache:mainfrom
Open
GH-48120: [C++][ODBC] Remove and replace IsComplexType with is_nested#48847AestheticAkhmad wants to merge 1 commit intoapache:mainfrom
AestheticAkhmad wants to merge 1 commit intoapache:mainfrom
Conversation
|
|
github-actions
bot
added
Component: C++
Component: FlightRPC
CI: Extra: C++
Member
|
CC @alinaliBQ |
Collaborator
|
Hi @AestheticAkhmad , thanks for raising the PR. We recently merged in the instructions to test ODBC in the `README. Could you test the changes locally in a Windows environment? Let me know if you have any questions on this. @lidavidm please help approve the workflow for this PR, thanks |
Collaborator
|
Another way you can test is downloading the msi from the workflow, and then running the test executables against it. I haven't tried this way before but it should work. After testing, please update the PR description |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This PR addresses the issue #48120
What changes are included in this PR?
Removed IsComplexType function and replaced it with is_nested function from type_traits.h
Are these changes tested?
No
IsComplexTypewithis_nestedfrom type_traits.h #48120