GH-49288: [C++][ORC] Add OrcFileFragment with stripe-level subsetting#49289
Open
ShreyeshArangath wants to merge 4 commits intoapache:mainfrom
Open
GH-49288: [C++][ORC] Add OrcFileFragment with stripe-level subsetting#49289ShreyeshArangath wants to merge 4 commits intoapache:mainfrom
ShreyeshArangath wants to merge 4 commits intoapache:mainfrom
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The ORC dataset integration currently lacks stripe-level subsetting support. When scanning ORC files through the Dataset API, there is no way to select specific stripes. The entire file is always read. This is a gap compared to ParquetFileFragment, which provides row-group-level subsetting via Subset(), row_groups(), and MakeFragment(..., row_groups).
What changes are included in this PR?
Modeled after the ParquetFileFragment design, we introduce stripe-aware ORC fragments so callers can target specific stripes during planning and scanning (instead of always reading the full file). This adds a small, consistent surface area in both C++ (and Python, separate issue):
An ORC-specific fragment type that can represent either the full file, or a subset of the file defined by stripe IDs
Fragment subsetting via a subset(...)/Subset(...) API, analogous to Parquet row-group subsetting.
Scan behavior that honors stripe selection, so execution reads only the requested stripes.
Correct row counting for subset fragments, where row counts reflect only the selected stripes
Are these changes tested?
Are there any user-facing changes?
The C++ API has the following changes
OrcFileFragmentclass withstripe_ids()andSubset()methodsOrcFileFormat::MakeFragment(source, partition_expression, physical_schema, stripe_ids)overloadThough, there are no breaking changes. Existing ORC scanning behavior is unchanged when no stripe IDs are specified.