Skip to content

Commit b687870

Browse files
authored
Fix flaky tests caused by secret overlap (#36526)
1 parent 30fd958 commit b687870

File tree

4 files changed

+15
-12
lines changed

4 files changed

+15
-12
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
22
"comment": "Modify this file in a trivial way to cause this test suite to run.",
3-
"modification": 31
3+
"modification": 32
44
}
55

sdks/python/apache_beam/transforms/core_it_test.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@
1919

2020
# pytype: skip-file
2121

22-
import random
23-
import string
22+
import sys
2423
import unittest
24+
from datetime import datetime
2525

2626
import pytest
2727

@@ -43,8 +43,9 @@ class GbekIT(unittest.TestCase):
4343
def setUp(self):
4444
if secretmanager is not None:
4545
self.project_id = 'apache-beam-testing'
46-
secret_postfix = ''.join(random.choice(string.digits) for _ in range(6))
47-
self.secret_id = 'gbek_secret_tests_' + secret_postfix
46+
py_version = f'_py{sys.version_info.major}{sys.version_info.minor}'
47+
secret_postfix = datetime.now().strftime('%m%d_%H%M%S') + py_version
48+
self.secret_id = 'gbekit_secret_tests_' + secret_postfix
4849
self.client = secretmanager.SecretManagerServiceClient()
4950
self.project_path = f'projects/{self.project_id}'
5051
self.secret_path = f'{self.project_path}/secrets/{self.secret_id}'

sdks/python/apache_beam/transforms/util_test.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
import math
2929
import random
3030
import re
31-
import string
31+
import sys
3232
import time
3333
import unittest
3434
import warnings
@@ -319,8 +319,9 @@ class GroupByEncryptedKeyTest(unittest.TestCase):
319319
def setUp(self):
320320
if secretmanager is not None:
321321
self.project_id = 'apache-beam-testing'
322-
secret_postfix = ''.join(random.choice(string.digits) for _ in range(6))
323-
self.secret_id = 'gbek_secret_tests_' + secret_postfix
322+
py_version = f'_py{sys.version_info.major}{sys.version_info.minor}'
323+
secret_postfix = datetime.now().strftime('%m%d_%H%M%S') + py_version
324+
self.secret_id = 'gbek_util_secret_tests_' + secret_postfix
324325
self.client = secretmanager.SecretManagerServiceClient()
325326
self.project_path = f'projects/{self.project_id}'
326327
self.secret_path = f'{self.project_path}/secrets/{self.secret_id}'

sdks/python/apache_beam/transforms/validate_runner_xlang_test.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,10 @@
5252

5353
import logging
5454
import os
55-
import random
56-
import string
55+
import sys
5756
import typing
5857
import unittest
58+
from datetime import datetime
5959

6060
import pytest
6161

@@ -334,8 +334,9 @@ class ValidateRunnerGBEKTest(unittest.TestCase):
334334
def setUp(self):
335335
if secretmanager is not None:
336336
self.project_id = 'apache-beam-testing'
337-
secret_postfix = ''.join(random.choice(string.digits) for _ in range(6))
338-
self.secret_id = 'gbek_secret_tests_' + secret_postfix
337+
py_version = f'_py{sys.version_info.major}{sys.version_info.minor}'
338+
secret_postfix = datetime.now().strftime('%m%d_%H%M%S') + py_version
339+
self.secret_id = 'gbek_validaterunner_secret_tests_' + secret_postfix
339340
self.client = secretmanager.SecretManagerServiceClient()
340341
self.project_path = f'projects/{self.project_id}'
341342
self.secret_path = f'{self.project_path}/secrets/{self.secret_id}'

0 commit comments

Comments
 (0)