Skip to content

[extensions-proto] Return correct TypeDescriptor for ProtoCoder (#34561)#34562

Merged
je-ik merged 1 commit intoapache:masterfrom
je-ik:34561-proto-coder-encoded-type-descriptor
Apr 24, 2025
Merged

[extensions-proto] Return correct TypeDescriptor for ProtoCoder (#34561)#34562
je-ik merged 1 commit intoapache:masterfrom
je-ik:34561-proto-coder-encoded-type-descriptor

Conversation

@je-ik
Copy link
Copy Markdown
Contributor

@je-ik je-ik commented Apr 7, 2025

Closes #34561


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@je-ik je-ik force-pushed the 34561-proto-coder-encoded-type-descriptor branch from 03d682f to 582a246 Compare April 7, 2025 15:07
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2025

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@je-ik
Copy link
Copy Markdown
Contributor Author

je-ik commented Apr 7, 2025

assign set of reviewers

@je-ik
Copy link
Copy Markdown
Contributor Author

je-ik commented Apr 7, 2025

The failure in precommit should not be related.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2025

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @chamikaramj for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@je-ik
Copy link
Copy Markdown
Contributor Author

je-ik commented Apr 8, 2025

R: @kennknowles

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2025

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@je-ik
Copy link
Copy Markdown
Contributor Author

je-ik commented Apr 21, 2025

assign set of reviewers

@je-ik
Copy link
Copy Markdown
Contributor Author

je-ik commented Apr 21, 2025

R: @Abacn

@github-actions
Copy link
Copy Markdown
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @m-trieu for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions
Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@je-ik je-ik merged commit 8d400da into apache:master Apr 24, 2025
17 checks passed
@je-ik je-ik deleted the 34561-proto-coder-encoded-type-descriptor branch April 24, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: ProtoCoder does not return correctly encoded TypeDescriptor

2 participants