Fix Docker authentication for Python ValidatesContainer Dataflow With RC tests

[aIbrahiim]

Fixes: #30525
Successful Run: https://github.com/aIbrahiim/beam/actions/runs/19069823983

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello @aIbrahiim, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue where Python ValidatesContainer Dataflow tests were failing due to a lack of proper Docker authentication with Google Container Registry. The changes introduce explicit gcloud auth configure-docker and docker login commands into the test execution script, ensuring that Docker can successfully pull and push images required for the tests. This fix significantly improves the reliability and stability of the CI/CD pipeline for these specific Dataflow tests.

Highlights

• Docker Authentication: Implemented necessary Docker authentication steps for Google Container Registry (GCR) within the run_validatescontainer.sh script to resolve previous authentication failures.
• Test Reliability: Resolved issues preventing Python ValidatesContainer Dataflow tests from running successfully by ensuring proper Docker login before test execution.

Ignored Files

• Ignored by pattern: .github/workflows/** (1)
  • .github/workflows/beam_PostCommit_Python_ValidatesContainer_Dataflow_With_RC.yml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[damccorm]

If we're already doing these steps in run_validatescontainer.sh, do we need it here as well?

[aIbrahiim]

The working workflow has docker auth steps so I followed that pattern as the failure was unauthorized authentication failed when the Python test called docker push, so I wanted to ensure auth was set up early
But you ae right that it's redundant, I will modify it

[damccorm]

Thanks

[aIbrahiim]

@damccorm error occured while trying to push the docker image to GCR : https://github.com/apache/beam/actions/runs/19071856336/job/54476581508

[aIbrahiim]

@damccorm error occured while trying to push the docker image to GCR : https://github.com/apache/beam/actions/runs/19071856336/job/54476581508

it might be related to google cloud constraints? or the workflow still needs authentication? @damccorm

[aIbrahiim]

../../build/gradleenv/2050596100/lib/python3.12/site-packages/google/cloud/aiplatform/models.py:52
/runner/_work/beam/beam/build/gradleenv/2050596100/lib/python3.12/site-packages/google/cloud/aiplatform/models.py:52: FutureWarning: Support for google-cloud-storage < 3.0.0 will be removed in a future version of google-cloud-aiplatform. Please upgrade to google-cloud-storage >= 3.0.0.
from google.cloud.aiplatform.utils import gcs_utils

[aIbrahiim]

here it is an auth problem https://github.com/apache/beam/actions/runs/19071856336/job/54476581562

[aIbrahiim]

I created new PR for fixing the errors appeared and modified the auth in the workflow to authenticate Docker only #36721