Skip to content

Fix Docker authentication for Python ValidatesContainer Dataflow With RC tests #36718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
damccorm merged 2 commits into from
Nov 4, 2025
Merged

Fix Docker authentication for Python ValidatesContainer Dataflow With RC tests #36718

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ed27b2
Added Docker authentication
aIbrahiim Nov 4, 2025
b75ac2c
removed the Docker auth step from the workflow
aIbrahiim Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/beam_PostCommit_Python_ValidatesContainer_Dataflow_With_RC.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,18 @@ jobs:
with:
java-version: default
python-version: ${{ matrix.python_version }}
- name: Authenticate to GCP
uses: google-github-actions/auth@v3
with:
service_account: ${{ secrets.GCP_SA_EMAIL }}
credentials_json: ${{ secrets.GCP_SA_KEY }}
- name: Set up Cloud SDK
uses: google-github-actions/setup-gcloud@v3
- name: Configure Docker auth for GCR
run: |
gcloud --quiet auth configure-docker us.gcr.io
gcloud --quiet auth configure-docker gcr.io
gcloud auth list
Copy link
Contributor

@damccorm damccorm Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're already doing these steps in run_validatescontainer.sh, do we need it here as well?

Copy link
Contributor Author

@aIbrahiim aIbrahiim Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The working workflow has docker auth steps so I followed that pattern as the failure was unauthorized authentication failed when the Python test called docker push, so I wanted to ensure auth was set up early
But you ae right that it's redundant, I will modify it

- name: Set PY_VER_CLEAN
id: set_py_ver_clean
run: |
Expand Down
5 changes: 5 additions & 0 deletions sdks/python/container/run_validatescontainer.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,11 @@ echo ">>> Successfully built and push container $CONTAINER"
cd sdks/python
SDK_LOCATION=$2

echo ">>> Configuring Docker authentication for GCR"
gcloud --quiet auth configure-docker us.gcr.io
gcloud --quiet auth configure-docker gcr.io
gcloud auth print-access-token | docker login -u oauth2accesstoken --password-stdin https://us.gcr.io

echo ">>> RUNNING DATAFLOW RUNNER VALIDATESCONTAINER TEST"
pytest -o log_cli=True -o log_level=Info -o junit_suite_name=$IMAGE_NAME \
-m=it_validatescontainer \
Expand Down
Loading