Skip to content

fix side-input existence deadline#34046

Merged
reuvenlax merged 1 commit intoapache:masterfrom
reuvenlax:fix_never_trigger
Feb 21, 2025
Merged

fix side-input existence deadline#34046
reuvenlax merged 1 commit intoapache:masterfrom
reuvenlax:fix_never_trigger

Conversation

@reuvenlax
Copy link
Copy Markdown
Contributor

Fix remaining location

@reuvenlax
Copy link
Copy Markdown
Contributor Author

R: @kennknowles

@github-actions
Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@reuvenlax
Copy link
Copy Markdown
Contributor Author

R: @slilichenko

Copy link
Copy Markdown
Contributor

@slilichenko slilichenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM. Perhaps undo reformatting of BigQueryIO.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to undo this change by the formatter - it will make the comments harder to read.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the formatter runs automatically now

@reuvenlax reuvenlax merged commit 5ca14c1 into apache:master Feb 21, 2025
25 checks passed
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.25%. Comparing base (f5ed586) to head (5b0924f).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #34046   +/-   ##
=========================================
  Coverage     59.25%   59.25%           
  Complexity     3272     3272           
=========================================
  Files          1164     1164           
  Lines        178325   178325           
  Branches       3413     3413           
=========================================
  Hits         105675   105675           
  Misses        69250    69250           
  Partials       3400     3400           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

VardhanThigle pushed a commit to VardhanThigle/beam that referenced this pull request Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants