Skip to content

Conversation

@robertwb
Copy link
Contributor


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@robertwb
Copy link
Contributor Author

R: @derrickaw
CC: @damccorm @rezarokni

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@robertwb robertwb force-pushed the yaml-deps branch 2 times, most recently from d2018e7 to cdb24de Compare February 28, 2025 16:53
return super().requires_inputs(typ, args)

def _with_extra_dependencies(self, dependencies):
external_provider = ExternalPythonProvider( #
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
external_provider = ExternalPythonProvider( #
external_provider = ExternalPythonProvider(

@codecov
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

Attention: Patch coverage is 66.26506% with 28 lines in your changes missing coverage. Please review.

Project coverage is 56.35%. Comparing base (76b0df9) to head (a4b2912).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
sdks/python/apache_beam/yaml/yaml_provider.py 51.06% 23 Missing ⚠️
sdks/python/apache_beam/yaml/yaml_transform.py 60.00% 4 Missing ⚠️
...beam/runners/portability/expansion_service_main.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #34073   +/-   ##
=========================================
  Coverage     56.35%   56.35%           
  Complexity     3286     3286           
=========================================
  Files          1173     1173           
  Lines        179087   179178   +91     
  Branches       3398     3398           
=========================================
+ Hits         100928   100982   +54     
- Misses        74904    74941   +37     
  Partials       3255     3255           
Flag Coverage Δ
python 81.29% <66.26%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@robertwb
Copy link
Contributor Author

I went ahead and skipped the test in the flaky environment, as it seems environmental. The other tests are pre-existing (and I'm seeing them in other PRs).

@robertwb robertwb merged commit e0b9d03 into apache:master Mar 18, 2025
94 of 97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants