[Dataflow Streaming] WindmillTimerInternals: Use a single map to store timer data + liveness#34292
Merged
scwhittle merged 2 commits intoapache:masterfrom Mar 19, 2025
Merged
Conversation
Contributor
Author
|
R: @scwhittle |
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
arunpandianp
commented
Mar 14, 2025
|
|
||
| // Wipe the unpersisted state | ||
| timers.clear(); | ||
| timerMap.clear(); |
Contributor
Author
There was a problem hiding this comment.
timerStillPresent was not cleared before, It is safe to clear both timerdata and boolen here since WindmillTimerInternals is recreated at the bundle level.
scwhittle
requested changes
Mar 14, 2025
...ava/worker/src/main/java/org/apache/beam/runners/dataflow/worker/WindmillTimerInternals.java
Outdated
Show resolved
Hide resolved
...ava/worker/src/main/java/org/apache/beam/runners/dataflow/worker/WindmillTimerInternals.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Run Java PreCommit |
talatuyarer
pushed a commit
to talatuyarer/beam
that referenced
this pull request
Mar 20, 2025
…e timer data + liveness (apache#34292)
prodriguezdefino
pushed a commit
to prodriguezdefino/beam-pabs
that referenced
this pull request
Mar 26, 2025
…e timer data + liveness (apache#34292)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#33578
Example
old profile:
new profile:
