Skip to content

SnowflakeIO: filter on db and schema when searching for existing table #34486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Abacn merged 1 commit into from
May 19, 2025
Merged

SnowflakeIO: filter on db and schema when searching for existing table #34486

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions ...ke/src/main/java/org/apache/beam/sdk/io/snowflake/services/SnowflakeBatchServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,8 @@ private void copyToTable(SnowflakeBatchServiceConfig config) throws SQLException
files = files.replaceAll(stagingBucketDir, "");
DataSource dataSource = dataSourceProviderFn.apply(null);

prepareTableAccordingCreateDisposition(dataSource, table, tableSchema, createDisposition);
prepareTableAccordingCreateDisposition(
dataSource, database, schema, table, tableSchema, createDisposition);
prepareTableAccordingWriteDisposition(dataSource, table, writeDisposition);

if (!storageIntegrationName.isEmpty()) {
Expand Down Expand Up @@ -193,6 +194,8 @@ private static boolean checkIfTableIsEmpty(ResultSet resultSet, int columnId)

private void prepareTableAccordingCreateDisposition(
DataSource dataSource,
String database,
String schema,
String table,
SnowflakeTableSchema tableSchema,
CreateDisposition createDisposition)
Expand All @@ -201,7 +204,7 @@ private void prepareTableAccordingCreateDisposition(
case CREATE_NEVER:
break;
case CREATE_IF_NEEDED:
createTableIfNotExists(dataSource, table, tableSchema);
createTableIfNotExists(dataSource, database, schema, table, tableSchema);
break;
}
}
Expand All @@ -222,11 +225,16 @@ private void prepareTableAccordingWriteDisposition(
}

private void createTableIfNotExists(
DataSource dataSource, String table, SnowflakeTableSchema tableSchema) throws SQLException {
DataSource dataSource,
String database,
String schema,
String table,
SnowflakeTableSchema tableSchema)
throws SQLException {
String query =
String.format(
"SELECT EXISTS (SELECT 1 FROM information_schema.tables WHERE table_name = '%s');",
table.toUpperCase());
"SELECT EXISTS (SELECT 1 FROM information_schema.tables WHERE table_catalog = '%s' AND table_schema = '%s' AND table_name = '%s');",
database.toUpperCase(), schema.toUpperCase(), table.toUpperCase());

runConnectionWithStatement(
dataSource,
Expand Down
Loading