Fix a flatten flaky test when two flattens are used sequentially.#34602
Merged
lostluck merged 1 commit intoapache:masterfrom Apr 10, 2025
Merged
Fix a flatten flaky test when two flattens are used sequentially.#34602lostluck merged 1 commit intoapache:masterfrom
lostluck merged 1 commit intoapache:masterfrom
Conversation
Contributor
|
Assigning reviewers. If you would like to opt out of this review, comment R: @lostluck for label go. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
lostluck
approved these changes
Apr 10, 2025
Contributor
lostluck
left a comment
There was a problem hiding this comment.
I like it. Essentially marking that we've examined it before. Unlikely to collide with SDK coder names, so it's acceptable as an approach.
This was referenced Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We see some test flakiness (https://github.com/apache/beam/actions/workflows/beam_PreCommit_Prism_Python.yml) after #34582.
Here is a simple pipeline to reproduce:
In #34582, we replace the coder ids in the input PCollections of each flatten transform. However, if there are multiple flatten transforms and they are connected to each other, the order of replacing matters:
Flatten1and thenFlatten2:side1andside2will beCoder(Tuple[str, int])side(flattened output ofside1andside2) andside3will beCoder(Tuple[str])Flatten2and thenFlatten1:side(flattened output ofside1andside2) andside3will beCoder(Tuple[str])side1andside2will also beCoder(Tuple[str])(same as the coder ofside)The first scenario will cause some problem during prism handling runner transform of flatten, because when it tries to collect elements of
Flatten2, it will get elements encoded withCoder(Tuple[str, int]))fromside1andside2, and elements encoded withCoder(Tuple[str])fromside3.addresses #34587