Skip to content

Fix SIGINT handler for StopOnExitJobServer #34748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lostluck merged 1 commit into from
Apr 26, 2025
Merged

Fix SIGINT handler for StopOnExitJobServer #34748

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion sdks/python/apache_beam/runners/portability/job_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,14 +72,22 @@ def __init__(self, job_server):
self._lock = threading.Lock()
self._job_server = job_server
self._started = False
# save original signal handler
self._original_sigint_handler = signal.getsignal(signal.SIGINT)

def _sigint_handler(self, sig, frame):
self.stop()
if callable(self._original_sigint_handler):
# call original signal handler to handle sigint gracefully
self._original_sigint_handler(sig, frame)

def start(self):
with self._lock:
if not self._started:
self._endpoint = self._job_server.start()
self._started = True
atexit.register(self.stop)
signal.signal(signal.SIGINT, self.stop)
signal.signal(signal.SIGINT, self._sigint_handler)
return self._endpoint

def stop(self):
Expand Down
Loading