Skip to content

Use Java 17 for Debezium IO #34747 #34751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Abacn merged 4 commits into from
Apr 28, 2025
Merged

Use Java 17 for Debezium IO #34747 #34751

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f8bba13
Use Java 17 for Debezium IO #34747
tkaymak Apr 27, 2025
b2b7515
update CHANGES.md
tkaymak Apr 27, 2025
85b90eb
adjust PreCommit Workflow
tkaymak Apr 28, 2025
bb9c3f7
Revert CHANGES.md
tkaymak Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/beam_PreCommit_Java_Debezium_IO_Direct.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,13 +85,19 @@ jobs:
github_job: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
- name: Setup environment
uses: ./.github/actions/setup-environment-action
with:
java-version: |
17
8
Copy link
Contributor

@Abacn Abacn Apr 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We now use Java 11 to build Beam (with Java 8 byte code compatibility). So change 8 -> 11

Copy link
Contributor Author

@tkaymak tkaymak Apr 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Adjusted to 11

- name: run Debezium IO build task
uses: ./.github/actions/gradle-command-self-hosted-action
with:
gradle-command: :sdks:java:io:debezium:build
arguments: |
-PdisableSpotlessCheck=true \
-PdisableCheckStyle=true \
-PtestJavaVersion=17 \
-Pjava17Home=$JAVA_HOME_17_X64 \
- name: run Debezium IO additional tasks
uses: ./.github/actions/gradle-command-self-hosted-action
with:
Expand All @@ -101,6 +107,8 @@ jobs:
arguments: |
-PdisableSpotlessCheck=true \
-PdisableCheckStyle=true \
-PtestJavaVersion=17 \
-Pjava17Home=$JAVA_HOME_17_X64 \
- name: Archive JUnit Test Results
uses: actions/upload-artifact@v4
if: ${{ !success() }}
Expand Down
2 changes: 1 addition & 1 deletion CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@

## I/Os

* Support for X source added (Java/Python) ([#X](https://github.com/apache/beam/issues/X)).
* Debezium IO now requires Java 17 (Java) ([#34747](https://github.com/apache/beam/issues/34747)).
Copy link
Contributor

@Abacn Abacn Apr 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change alone does not affect artifact build yet. We can defer the announcement after Debezium client version upgrade

Copy link
Contributor Author

@tkaymak tkaymak Apr 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Abacn Thank you! Reverted


## New Features / Improvements

Expand Down
Loading