Skip to content

Conversation

@claudevdm
Copy link
Collaborator

@claudevdm claudevdm commented Apr 28, 2025

  • Make dill optional, but still include it in base image. If there are dependency conflicts the dill version should be updated when containers start up
  • Use selected pickle library for encoding types in FastPrimitiveCoder. For update compatibility users will need to set pickle_library=dill. We might have to also guard this change behind update compatibility flag incase it doesnt fail update compat checks but encoding starts failing. Alternatively we can fallback to using dill for decoding the type if cloudpickle is selected and decoding the type fails, but this might affect performance since decode_type is called on each element being decoded.
  • Add CloudpickleCoder option

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@codecov
Copy link

codecov bot commented Apr 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.50%. Comparing base (930d14a) to head (64d2473).
Report is 4 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #34769      +/-   ##
============================================
- Coverage     56.50%   56.50%   -0.01%     
  Complexity     3289     3289              
============================================
  Files          1180     1180              
  Lines        181262   181239      -23     
  Branches       3399     3399              
============================================
- Hits         102423   102402      -21     
+ Misses        75580    75577       -3     
- Partials       3259     3260       +1     
Flag Coverage Δ
go 28.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@claudevdm
Copy link
Collaborator Author

PreCommit Python PVR Flink is flakey, saw this failure on other PRs/Runs

@github-actions github-actions bot removed the docker label May 5, 2025
@claudevdm claudevdm force-pushed the dill-optional branch 2 times, most recently from 544ce26 to 4b8e5e2 Compare May 5, 2025 17:05
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2025

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jul 5, 2025
@github-actions
Copy link
Contributor

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this Jul 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant