Skip to content

Conversation

@jrmccluskey
Copy link
Contributor

Updates workflows to publish 3.13 containers and execute test suites against Python 3.13.

Closes #34869


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the build label May 27, 2025
@codecov
Copy link

codecov bot commented May 29, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.20%. Comparing base (3534960) to head (32b26dd).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
sdks/python/setup.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #35056      +/-   ##
============================================
- Coverage     40.20%   40.20%   -0.01%     
  Complexity     3386     3386              
============================================
  Files          1220     1220              
  Lines        186149   186175      +26     
  Branches       3523     3523              
============================================
+ Hits          74839    74844       +5     
- Misses       107955   107976      +21     
  Partials       3355     3355              
Flag Coverage Δ
python 40.54% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added stale and removed stale labels Jul 29, 2025
@github-actions
Copy link
Contributor

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added stale and removed stale labels Sep 29, 2025
@github-actions github-actions bot removed the docker label Sep 30, 2025
@github-actions github-actions bot added the docker label Oct 1, 2025
@jrmccluskey jrmccluskey marked this pull request as ready for review October 2, 2025 17:20
@jrmccluskey
Copy link
Contributor Author

The only current hangup is that I cannot get a clean precommit run off of the branch, but the test failures aren't consistent so it's hard to tell if we're really getting breakages or just flakes.

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - just had a few minor comments

# (TODO): https://github.com/apache/beam/issues/21971
# Add python 3.10 to dataflow test-suites
dataflow_precommit_it_task_py_versions=3.9,3.12
dataflow_precommit_it_task_py_versions=3.9,3.13
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be a follow up (non-blocking here) - it would be nice to refactor 3.9 and 3.13 into max_py_version and min_py_version variables

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

'torch',
'transformers',
],
'p313_ml_test': [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than adding a p3XX_ml_test version for every supported python version, could we rename p312_ml_test to something like ml_basic_test? I think ml_test is just this + dill and tensorflow-transform FWIW

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is technically breaking, but I would be surprised if anyone is depending on this directly (and we could call this out in CHANGES)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of depends on how we want to go about it, since the datatables dependency does work in 3.12 but does not support 3.13. I'm not sure how many test cases that potentially takes off of 3.12 runs, but I am not opposed to it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, what if we do something in the middle? We could define a ml_base dependency like we do with some other deps (e.g.

dataframe_dependency = [
)

Then we can have:

'ml_test': [
   'datatable',
   'dill',
   'tensorflow-transformers'
] + ml_base,
'p312_ml_test': [
   'datatable'
] + ml_base,
'p313_ml_test': ml_base

Thoughts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

took a run at it in the latest version

@jrmccluskey
Copy link
Contributor Author

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once checks pass

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2025

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@jrmccluskey
Copy link
Contributor Author

apache_beam.ml.rag.enrichment.milvus_search_it_test.TestMilvusSearchEnrichment seems to be consistently red on python 3.12.

@damccorm
Copy link
Contributor

damccorm commented Oct 3, 2025

Remaining test failures look like #36377

@jrmccluskey
Copy link
Contributor Author

sounds good, thank you

@jrmccluskey jrmccluskey merged commit a03e96a into master Oct 3, 2025
108 of 125 checks passed
uses: ./.github/actions/setup-environment-action
with:
python-version: 3.12
python-version: 3.13
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests failing due to "sh: 1: python3.12: not found" after this change

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed by #36389

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add Support for Python 3.13

5 participants