[KafkaIO] Report unknown backlog size when latest offset lags behind next offset#35086
[KafkaIO] Report unknown backlog size when latest offset lags behind next offset#35086liferoad merged 1 commit intoapache:masterfrom
Conversation
|
Assigning reviewers: R: @chamikaramj for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Reminder, please take a look at this pr: @chamikaramj @Dippatel98 |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @robertwb for label java. Available commands:
|
|
Reminder, please take a look at this pr: @robertwb @johnjcasey |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @kennknowles for label java. Available commands:
|
|
Reminder, please take a look at this pr: @kennknowles @liferoad |
|
I actually wonder if this could have weird issues? I guess the presumption of the prior code is that we are "caught up" if the next offset has caught up to the latest offset. This could be temporarily incorrect, waiting on the next refresh, but that could be better than oscillating between unknown & known backlog numbers? |
|
Reminder, please take a look at this pr: @kennknowles @liferoad |
@sjvanrossum are we good to merge this PR? |
|
@liferoad yes, this is good to merge. 👍 |
The periodic refresh of a partition's end offset may lag behind the consumption from that partition.
Instead of reporting no backlog when
latestOffset < nextOffsetthe backlog should be reported as unknown (represented by -1).Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.