Move recently added yaml tests to tmp folder to lower precommit runtime #35096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrickaw
force-pushed
the
fixTFRecordFailure
branch
from
e4db227 to
be8a311
Compare
Collaborator
Author
|
Run PythonDocs Precommit |
Collaborator
Author
|
Run Yaml_Xlang_Direct PreCommit |
Collaborator
Author
|
We are back to green for yaml_xlang_direct with this PR. |
Abacn
reviewed
May 30, 2025
Contributor
Abacn
left a comment
Abacn
left a comment
There was a problem hiding this comment.
We can just name it "extended_tests" / "complete_tests", then when we setup PostCommit workflow no need to move it around again
Abacn
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seeing failures with precommit yaml xlang probably due to increase in run times due to these PRs -
Short term plan is to move most of the recently added tests to a tmp folder to not run them and lower the precommit time drastically.
Long term plan is to move precommit yaml xlang direct to postcommit.
Fixes the first part of #35098.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.