Extending WindowedValue with ElementMetadata#35180
Closed
stankiewicz wants to merge 4 commits intoapache:masterfrom
Closed
Extending WindowedValue with ElementMetadata#35180stankiewicz wants to merge 4 commits intoapache:masterfrom
stankiewicz wants to merge 4 commits intoapache:masterfrom
Conversation
Contributor
Author
|
R: @kennknowles |
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
kennknowles
requested changes
Jun 17, 2025
| Instant getTimestamp(); | ||
|
|
||
| @Nullable | ||
| ElementMetadata getElementMetadata(); |
Member
There was a problem hiding this comment.
I think now that this is user-facing it will not be in the interface like this. Instead, the specific pieces of metadata will be in the interface and the implementation(s) will return it.
| */ | ||
| <OtherT> WindowedValue<OtherT> withValue(OtherT value); | ||
|
|
||
| WindowedValue<T> withElementMetadata(@Nullable ElementMetadata elementMetadata); |
Member
There was a problem hiding this comment.
We don't need this one - instead OutputBuilder will have setTracingContext and similar methods and the builder will plumb it to the constructor of the WindowedValue implementation.
Collaborator
|
waiting on author |
Contributor
|
hey @stankiewicz, is this PR still relevant? |
Contributor
Author
|
replaced with #36373 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Following #34971
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.