Add display_data to AppliedPTransforms#35380
Merged
damccorm merged 4 commits intoapache:masterfrom Jun 26, 2025
Merged
Conversation
hjtran
changed the title
Contributor
|
Assigning reviewers: R: @damccorm for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
damccorm
reviewed
Jun 26, 2025
Contributor
damccorm
left a comment
damccorm
left a comment
There was a problem hiding this comment.
Thanks - this generally lgtm, just had one question
sdks/python/apache_beam/pipeline.py
Outdated
| self._perform_exernal_transform_test(transform_node.transform) | ||
|
|
||
|
|
||
| class DisplayDataContainer(HasDisplayData): |
Contributor
There was a problem hiding this comment.
Is this class actually used?
Contributor
Author
There was a problem hiding this comment.
Ah sorry, leftover from a prior implementation that I scrapped. I originally grabbed all display data from the transform at AppliedPTransform instantiation time, but turns out some transforms define their display_data at transform expansion time (which is after AppliedPTransform instantiation time).
Will remove this
damccorm
approved these changes
Jun 26, 2025
shunping
pushed a commit
to shunping/beam
that referenced
this pull request
Jun 27, 2025
* define display_data as a appliedptransform attribute similar to annotatoins * Adjust for transforms that define their display data at expand time * extend base case unit test * remove unused diplaydatacontainer class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
display_dataattribute toAppliedPTransforms, similar toannotationsandresource_hints. This gives us a little more flexibility with adding display data, e.g. if someone wants to create aPipelineVisitorthat adds general display data for every ptransform (like a link to github pointing to the source)Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.