Skip to content

Adds a pipeline option to terminate processing of an element after a timeout (python)#35391

Merged
tvalentyn merged 52 commits intoapache:masterfrom
LEEKYE:add_dataflow_option_python
Aug 28, 2025
Merged

Adds a pipeline option to terminate processing of an element after a timeout (python)#35391
tvalentyn merged 52 commits intoapache:masterfrom
LEEKYE:add_dataflow_option_python

Conversation

@LEEKYE
Copy link
Contributor

@LEEKYE LEEKYE commented Jun 22, 2025

Address the issue #35174 in Python SDK


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@LEEKYE
Copy link
Contributor Author

LEEKYE commented Jun 24, 2025

R: @apanich
R: @Abacn
R: @ryan-mbuashundip
R: @scwhittle

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

LEEKYE and others added 3 commits June 26, 2025 14:46
@codecov
Copy link

codecov bot commented Jun 26, 2025

Codecov Report

Attention: Patch coverage is 63.33333% with 11 lines in your changes missing coverage. Please review.

Project coverage is 54.54%. Comparing base (cecfa61) to head (42e3e9a).
Report is 82 commits behind head on master.

Files with missing lines Patch % Lines
...python/apache_beam/runners/worker/worker_status.py 70.83% 7 Missing ⚠️
...ks/python/apache_beam/runners/worker/sdk_worker.py 33.33% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #35391      +/-   ##
============================================
+ Coverage     54.50%   54.54%   +0.03%     
  Complexity     1559     1559              
============================================
  Files          1035     1037       +2     
  Lines        161595   162038     +443     
  Branches       1139     1139              
============================================
+ Hits          88084    88390     +306     
- Misses        71380    71517     +137     
  Partials       2131     2131              
Flag Coverage Δ
python 80.81% <63.33%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LEEKYE LEEKYE requested a review from ryan-mbuashundip July 7, 2025 16:39
Copy link
Contributor

@ryan-mbuashundip ryan-mbuashundip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add @kennknowles as a reviewer.

@LEEKYE
Copy link
Contributor Author

LEEKYE commented Jul 31, 2025

R: @kennknowles

Copy link
Contributor

@tvalentyn tvalentyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the lint as well.

@tvalentyn tvalentyn merged commit 8e0f35f into apache:master Aug 28, 2025
85 of 87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants