-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Support Protobuf 6.x. #35477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Protobuf 6.x. #35477
Conversation
de5991e to
42316a7
Compare
|
Assigning reviewers: R: @damccorm for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
damccorm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - this generally LGTM. @jrmccluskey would you mind taking a look? (any useful context I might be missing from the last protobuf upgrade #32679 ?)
|
unless there is some urgency, I would do it after the release cut, update dev containers, and test with internal user base to have more time to detect potential performance regressions. protobuf upgrades are hit-or-miss in my experience. |
|
Reminder, please take a look at this pr: @damccorm |
|
Merging since the cut has passed |
Why? Currently Apache Beam pins protobuf<6.0.0.dev0. Protobuf 6.30.0 was released on March 4, 2025: https://pypi.org/project/protobuf/6.30.0/, https://github.com/protocolbuffers/protobuf/releases/tag/v30.0 is the corresponding release.
Also fixed two flaky tests that became more flaky with the new Protobuf version. They were flaky because Protobuf doesn't guarantee map iteration order, so the sampler instances created here doesn't guarantee
'a'is the first and'b'is the second sampler when the tests useself.make_test_descriptor(outputs=['a', 'b']).Fixes #35432.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.