Skip to content

Conversation

@yilei
Copy link
Contributor

@yilei yilei commented Jun 29, 2025

Why? Currently Apache Beam pins protobuf<6.0.0.dev0. Protobuf 6.30.0 was released on March 4, 2025: https://pypi.org/project/protobuf/6.30.0/, https://github.com/protocolbuffers/protobuf/releases/tag/v30.0 is the corresponding release.

Also fixed two flaky tests that became more flaky with the new Protobuf version. They were flaky because Protobuf doesn't guarantee map iteration order, so the sampler instances created here doesn't guarantee 'a' is the first and 'b' is the second sampler when the tests use self.make_test_descriptor(outputs=['a', 'b']).

Fixes #35432.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@yilei yilei force-pushed the protobuf branch 3 times, most recently from de5991e to 42316a7 Compare July 1, 2025 05:23
@yilei yilei marked this pull request as ready for review August 16, 2025 23:04
@github-actions
Copy link
Contributor

Assigning reviewers:

R: @damccorm for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - this generally LGTM. @jrmccluskey would you mind taking a look? (any useful context I might be missing from the last protobuf upgrade #32679 ?)

@tvalentyn tvalentyn requested a review from jrmccluskey August 26, 2025 16:48
@tvalentyn
Copy link
Contributor

unless there is some urgency, I would do it after the release cut, update dev containers, and test with internal user base to have more time to detect potential performance regressions. protobuf upgrades are hit-or-miss in my experience.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2025

Reminder, please take a look at this pr: @damccorm

@damccorm
Copy link
Contributor

damccorm commented Sep 3, 2025

Merging since the cut has passed

@damccorm damccorm merged commit 9adc8dc into apache:master Sep 3, 2025
96 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Support Protobuf 6.x in Python SDK

3 participants