workflows: Capture Docker in Docker tests in beam_PreCommit_Python_Coverage workflow#35954
Conversation
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
6945b23 to
23a1a33
Compare
|
Hey @damccorm, I think this PR would solve this issue #35920 (comment). It turned out that ML tests run also in that workflow |
damccorm
left a comment
There was a problem hiding this comment.
Thanks - trying this here - https://github.com/apache/beam/actions/runs/17220391007
|
Assigning reviewers: R: @Abacn for label build. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
The tests |
|
Removing now the |
| beam_PreCommit_Python_Coverage: | ||
| name: ${{ matrix.job_name }} (${{ matrix.job_phrase }}) | ||
| runs-on: [self-hosted, ubuntu-20.04, highmem] | ||
| name: ${{ matrix.job_name }} (${{ matrix.job_phrase }} ${{ matrix.python_version }}) |
There was a problem hiding this comment.
Instead of including python_version, could we include the os? That way the generated job names will be different per job
There was a problem hiding this comment.
Instead of including python_version, could we include the os? That way the generated job names will be different per job
Added OS label to workflow (job_name and test results). Perhaps we can leave the python_version since this workflow currently runs on the default python version which is 3.9 in future potentially this can run on multiple python versions?
|
Hey @damccorm, can you please take another look? I have removed |
|
Cherry-picking those commits in that PR #35920. Closing this PR |
Motivation and Context
Addresses #35920 (comment)
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.