Skip to content

Conversation

@damccorm
Copy link
Contributor

@damccorm damccorm commented Sep 19, 2025

Java version of #36213. Add a transform which allows users to use a secret manager to ensure that any GBK data is encrypted before being sent to a runner. This allows users to avoid unencrypted data at rest when using GBK.

Part of #36214


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the java label Sep 19, 2025
@github-actions github-actions bot added the build label Sep 19, 2025
@damccorm damccorm changed the title [WIP] Java GBEK (AI generated) [WIP] Java GBEK Sep 23, 2025
@damccorm
Copy link
Contributor Author

Workflow failures are unrelated to this PR (license issues and an unrelated test), so this should be ready for review

@damccorm damccorm marked this pull request as ready for review September 29, 2025 20:36
@damccorm damccorm changed the title [WIP] Java GBEK Java GBEK Sep 29, 2025
@damccorm
Copy link
Contributor Author

assign set of reviewers

@github-actions
Copy link
Contributor

Assigning reviewers:

R: @kennknowles for label java.
R: @liferoad for label build.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@damccorm damccorm changed the title Java GBEK Java GroupByEncryptedKey Sep 29, 2025
@damccorm
Copy link
Contributor Author

damccorm commented Oct 1, 2025

R: @claudevdm since you have context from #36213

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@damccorm
Copy link
Contributor Author

damccorm commented Oct 4, 2025

RAT failures will be fixed in #36386

@damccorm damccorm merged commit c1fc369 into master Oct 4, 2025
27 of 29 checks passed
@damccorm damccorm deleted the users/damccorm/java-gbek branch October 4, 2025 12:04
@codecov
Copy link

codecov bot commented Oct 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 36.06%. Comparing base (d6422d1) to head (9b43d74).
⚠️ Report is 146 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #36217   +/-   ##
=========================================
  Coverage     36.06%   36.06%           
  Complexity     1618     1618           
=========================================
  Files          1057     1057           
  Lines        164135   164135           
  Branches       1165     1165           
=========================================
  Hits          59196    59196           
  Misses       102789   102789           
  Partials       2150     2150           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants