Skip to content

[Java] Fix CassandraIO ReadFn to quote column names for reserved keywords #36459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Abacn merged 2 commits into from
Dec 2, 2025
Merged

[Java] Fix CassandraIO ReadFn to quote column names for reserved keywords #36459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79fd87b
Fix CassandraIO ReadFn to quote column names for reserved keywords
Suvrat1629 Oct 9, 2025
8a217ab
Minor fixes
Suvrat1629 Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/ReadFn.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ public void processElement(@Element Read<T> read, OutputReceiver<T> receiver) th
session.getCluster().getMetadata().getKeyspace(read.keyspace().get())
.getTable(read.table().get()).getPartitionKey().stream()
.map(ColumnMetadata::getName)
.map(ReadFn::quoteIdentifier)
.collect(Collectors.joining(","));

String query = generateRangeQuery(read, partitionKey, read.ringRanges() != null);
Expand Down Expand Up @@ -148,4 +149,13 @@ private static String buildInitialQuery(Read<?> spec, Boolean hasRingRange) {
private static String getJoinerClause(String queryString) {
return queryString.toUpperCase().contains("WHERE") ? " AND " : " WHERE ";
}

static String quoteIdentifier(String identifier) {
if (identifier == null) {
return null;
}
// Escape any existing double quotes by doubling them
String escaped = identifier.replace("\"", "\"\"");
return "\"" + escaped + "\"";
}
}
Loading
Loading